feat(organization): backfill Asset search field for owner label TASK-1334 #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
noliveleger
changed the title
Guitlle
approved these changes
Dec 19, 2024
| from kpi.models.asset import Asset | ||
|
|
||
|
|
||
| def run(): |
There was a problem hiding this comment.
Should we have unit tests for at least some of these migrations? Though, I would expect them to get tested when devs pull from main and the local environment executes them from time to time. But maybe just for QA purposes, either having unit tests or reproducible previews.
There was a problem hiding this comment.
We decided to do simple tests (e.g.: validate the data is correctly added) in another PR.
Guitlle
approved these changes
Dec 20, 2024
noliveleger
deleted the
1334-back-fill-asset-search-field-for-owner-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Populated the asset search field to include the owner username and organization name for improved search functionality.
📖 Description
The asset search field has been updated to include tthe owner username and organization name, ensuring better usability when searching for asset owner labels. This backfill operation populates the field for existing assets where the owner label was previously missing.