Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Exclude 'osx-x86_64' and 'osx-arm64' for supafaust #131

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

garbear
Copy link
Member

@garbear garbear commented Aug 12, 2024

Description

Similar to #130, this PR adds excluded platforms that supafaust has failed to build on since the beginning.

This is due to Beetle Supafaust not compiling on macOS versions since Big Sur (version 11.0).

Errors are:

mednafen/mthreading/MThreading_POSIX.cpp:585:5: error: use of undeclared identifier 'sem_timedwait'; did you mean Sem_TimedWait'?
 if(sem_timedwait(&sem->s, &abstime))
    ^~~~~~~~~~~~~
    Sem_TimedWait

mednafen/mthreading/MThreading_POSIX.cpp:585:19: error: cannot initialize a parameter of type 'Mednafen::MThreading::Sem *with an rvalue of type 'sem_t *' (aka 'int *')
 if(sem_timedwait(&sem->s, &abstime))
                  ^~~~~~~

How has this been tested?

Build succeeds on remaining platforms (win/android): https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-game%2Fgame.libretro.supafaust/detail/master/117/pipeline

This is due to Beetle Supafaust not compiling on macOS versions since
Big Sur (version 11.0).

Errors are:

  mednafen/mthreading/MThreading_POSIX.cpp:585:5: error: use of undeclared identifier 'sem_timedwait'; did you mean 'Sem_TimedWait'?
   if(sem_timedwait(&sem->s, &abstime))
      ^~~~~~~~~~~~~
      Sem_TimedWait

  mednafen/mthreading/MThreading_POSIX.cpp:585:19: error: cannot initialize a parameter of type 'Mednafen::MThreading::Sem *' with an rvalue of type 'sem_t *' (aka 'int *')
   if(sem_timedwait(&sem->s, &abstime))
                    ^~~~~~~
@garbear garbear merged commit 936731c into kodi-game:master Aug 15, 2024
1 of 2 checks passed
@garbear garbear deleted the supafaust-exclude branch August 15, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant