Rename single settings category from "Settings" to "General" #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
garbear
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the main (and only) settings category from "Settings" to "General".
"Settings" already appears on the screen in the dialog title. "General" is a better label and is more consistent with the rest of Kodi.
Motivation and context
Noticed by @jjd-uk here: xbmc/xbmc#25598 (comment)
How has this been tested?
Locally
I modified a local add-on by hand. Tested in the Advanced Settings in-game dialog.
Before:
After:
Azure CI script
I ran the Azure CI script on Yabause and it pushed a new version (0.9.15.61) to the repo. Jenkins picked up the new version and uploaded binaries to the mirrors. Tested in the add-on browser.
Before:
TODO
After:
TODO: Take a screenshot when the update deploys in 24 hr