add_image_reference: improve virtual roots handling #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
force-pushed
the
more-virtual-packages
branch
from
934104f to
37e96e5
Compare
When the input SBOM had two or more "virtual roots", the script did not work correctly; there was a chance it would only delete one of them. The root cause was deleting items from a list while iterating over it. Iterate over a copy of the list instead. Signed-off-by: Adam Cmiel <[email protected]>
When scanning a directory, Syft (and perhaps cachi2 as well - to be
determined) uses the directory name for the root element. The element
may look e.g. like this
{
"SPDXID": "SPDXRef-DocumentRoot-Directory-.-some-directory",
"name": "./some-directory"
}
Consider such elements to be "virtual roots" as well.
Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
more-virtual-packages
branch
from
37e96e5 to
9c1a572
Compare
tnevrlka
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for more details