remove release from sbom-utility-scripts GH action #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Jan 8, 2025
Comment on lines
36
to
58
| - name: Run tox checks for base-images-sbom-script | ||
| run: | | ||
| python3 -m pip install tox | ||
| cd ./sbom-utility-scripts/scripts/base-images-sbom-script/app/ | ||
| tox | ||
|
|
||
| - name: Run tox checks for merge-cachi2-sboms-script | ||
| run: | | ||
| python3 -m pip install tox | ||
| cd ./sbom-utility-scripts/scripts/merge-cachi2-sboms-script/ | ||
| tox | ||
|
|
||
| - name: Run tox checks for index-image-sbom-script | ||
| run: | | ||
| python3 -m pip install tox | ||
| cd ./sbom-utility-scripts/scripts/index-image-sbom-script/ | ||
| tox | ||
|
|
||
| - name: Run tox checks for index-image-sbom-script | ||
| run: | | ||
| python3 -m pip install tox | ||
| cd ./sbom-utility-scripts/scripts/add-image-reference-script/ | ||
| tox |
There was a problem hiding this comment.
Maybe we should keep this part? I don't think we have a Konflux replacement for running the unit tests
tnevrlka
force-pushed
the
remove-sbom-utility-scripts-gh-action
branch
from
f45a8a2 to
cf3db68
Compare
tnevrlka
changed the title
tnevrlka
force-pushed
the
remove-sbom-utility-scripts-gh-action
branch
2 times, most recently
from
4e29bc2 to
212665a
Compare
- Build and release of sbom-utility-scripts image is now done via Konflux - The `Build Image` and `Push to Quay` steps are no longer necessary - Tox checks are still useful as testing though - Since the workflow is now not building anymore, rename to `test-sbom-utility-scripts`
tnevrlka
force-pushed
the
remove-sbom-utility-scripts-gh-action
branch
from
212665a to
7f9eae5
Compare
chmeliik
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build ImageandPush to Quaysteps are no longer necessarytest-sbom-utility-scripts