-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support git submodules for source containers #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
approved these changes
Mar 20, 2024
cgwalters
reviewed
Mar 20, 2024
chmeliik
reviewed
Mar 20, 2024
chmeliik
reviewed
Mar 20, 2024
ralphbean
force-pushed
the
git-submodules
branch
from
March 21, 2024 01:57
3f3ce9f
to
920f08c
Compare
We found that the bootc project wished to use a git submodule to make managing their downstream repo's relationship to their upstream repo easy. This change makes it so that the source archive of the git repository includes submodule content. Signed-off-by: Ralph Bean <[email protected]>
ralphbean
force-pushed
the
git-submodules
branch
from
March 21, 2024 18:15
920f08c
to
5805b60
Compare
chmeliik
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
1 task
tkdchen
reviewed
Mar 25, 2024
"--transform", | ||
f"s,^,{name_sha}/,", | ||
"-T-", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about set --owner=0 --group=0 --mode='a+rw'
explicitly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the bootc project wished to use a git submodule to make managing their downstream repo's relationship to their upstream repo easy.
This change makes it so that the source archive of the git repository includes submodule content.