Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve source image by image manifest #69

Merged

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Apr 23, 2024

STONEBLD-1831

Source container image built by Konflux has tag in format
manifest_digest.src, where the manifest_digest is the binary image
manifest. This commit adds an additional resolver this kind of source
container images pulled from allowed registries.

@tkdchen
Copy link
Contributor Author

tkdchen commented Apr 23, 2024

Require #66 to be merged first.

@tkdchen tkdchen force-pushed the STONEBLD-1831-resolve-konflux-source-image branch from 1bde0a4 to 4da1443 Compare April 23, 2024 03:40
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #66 is merged

STONEBLD-1831

Source container image built by Konflux has tag in format
manifest_digest.src, where the manifest_digest is the binary image
manifest. This commit adds an additional resolver this kind of source
container images pulled from allowed registries.

Signed-off-by: Chenxiong Qi <[email protected]>
@tkdchen tkdchen force-pushed the STONEBLD-1831-resolve-konflux-source-image branch from 4da1443 to 381640f Compare April 25, 2024 01:46
@tkdchen
Copy link
Contributor Author

tkdchen commented Apr 25, 2024

Rebased. No change to the commit.

@tkdchen tkdchen merged commit a98d5f9 into konflux-ci:main Apr 25, 2024
5 checks passed
@tkdchen tkdchen deleted the STONEBLD-1831-resolve-konflux-source-image branch April 25, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants