-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add GitHub Actions #451
Conversation
References <koreader#443 (comment)>.
At first I figured Travis would be easier (i.e., same config, or so I assumed), but I spent some 10 times as much trying to get that to work and it's refusing to see the repo. GitHub Actions took a couple of minutes. Edit: just a few minor things remaining in the script. |
Naïve workaround, see actions/runner#342
a4075fd
to
1da77e2
Compare
@poire-z Didn't you say something about that JSON stuff no longer being relevant? |
I remember I did (but not really what :) So, it's not used, but it kinda can be some reference (although duplicated with textlang.cpp, but I think we kept them in-sync).
|
It doesn't happen locally for me, so I don't want to spend time on something that I seem to recall you saying wasn't necessary anymore. |
Well, it's a good opportunity to understand the platform pecularities - before we move the more complex frontend :) |
@@ -26,7 +30,7 @@ for pattern in "${pattern_files[@]}"; do | |||
xmllint "$pattern" >/dev/null || SHELLSCRIPT_ERROR=1 | |||
done | |||
|
|||
changed_files="$(git diff --name-only "$TRAVIS_COMMIT_RANGE" | grep -E '\.([CcHh]|[ch]pp)$')" | |||
changed_files="$(git diff --name-only origin/master HEAD | grep -E '\.([CcHh]|[ch]pp)$')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need some more work to replicate $TRAVIS_COMMIT_RANGE, but it's probably just fine.
How do I solve this ? :/
|
^Just needed to also check [x] Workflow to that personal token I was forced to made some months ago ;) |
git push -f etc. |
Sorry, small mobile screen. My bad. No idea. |
It's solved :)
|
Follow-up to <koreader#451>.
References #443 (comment).
This change is