-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add stylelint to prevent typos in CSS #556
Conversation
You should ignore all the obsolete ones we won't ever touch, and just check epub.css and html5.css (and fb2.css maybe but it has lots of non-HTML element names). Lots of noise indeed :) |
It seemed to be unhappy with Anyway, I think this should about do it. |
That's in the old/current html5.css, that will be replaced in #555. |
Looks ok to me, we'll see what it does with #555. |
"no-duplicate-selectors": [true, { "severity": "warning" }], | ||
"property-no-unknown": [true, { | ||
"ignoreProperties": [ | ||
"binding", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: can be removed after #555.
In reply to #555 (comment)
This is an initial poc. Some of the rules like
length-zero-no-unit
definitely make sense to me, but the existing code is full of things like0px
and I dislike changing things for the sake of changing them.For
-cr-etc
I think we should be able to define acustom-property-pattern
(as a regex).For
selector-type-no-unknown
we should do something like"ignoreTypes": ["genre", "author", "etc"]
. Disabling it completely would probably defeat the purpose.And so on.
I don't know if I'll continue on this tonight, but this way the (rather excessive) list of complaints is already available to see.
This change is