Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvxml: fix regression #583

Closed
wants to merge 1 commit into from
Closed

lvxml: fix regression #583

wants to merge 1 commit into from

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jul 24, 2024 •
edited by Frenzie
Loading

Missing inline image in FB2 files (koreader/koreader#12212), revert:

  • 8b1cb64: reduce duplicate code
  • 40082dc: optimize tlen calculation
  • 9d70a2e: delay calculation of last_split_txtlen

Low effort fix if we decide to just scrap those 3 commits.

This change is Reviewable

@benoit-pierre
lvxml: fix regression
4d4b852 
Missing inline image in FB2 files, revert:
- 8b1cb64: reduce duplicate code
- 40082dc: optimize `tlen` calculation
- 9d70a2e: delay calculation of last_split_txtlen
@benoit-pierre benoit-pierre mentioned this pull request Jul 24, 2024
Closed
@poire-z
Copy link
Contributor

poire-z commented Jul 24, 2024

Pinging @bbshelper here too, if he is up for some medium effort fix :)

@bbshelper
Copy link
Contributor

Just be back from a long vacation :) Let me take a look.

@benoit-pierre
Copy link
Contributor Author

Closing in favor of #584.

@benoit-pierre benoit-pierre deleted the pr/fix_lvxml_regression branch July 28, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @poire-z @bbshelper