Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve macOS CI build #1686

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Nov 1, 2023

  • fix cache handling: the wrong path was configured, so the cache was not saved. Also tweak use so the cache is still saved on cancellation / failure.
  • build checkout phase: update action so a full clone with filtering can be used (so tags are fetched and koreader's version is correct).

This change is Reviewable

Update action so a full clone with filtering can be used
(so tags are fetched and koreader's version is correct).
The wrong path was configured, so the cache was not saved. Also
tweak use so the cache is still saved on cancellation / failure.
@Frenzie Frenzie merged commit 8bf72bb into koreader:master Nov 1, 2023
2 checks passed
@Frenzie
Copy link
Member

Frenzie commented Nov 1, 2023

Thanks!

@benoit-pierre benoit-pierre deleted the pr/improve_macos_ci_build branch November 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants