optimize gettext / glib builds #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an aside and I don't know if it matters, but isn't the glib becoming a bit old? |
|
It's not too fresh, yeah. |
|
Yeah, newer releases switched to meson and I didn't have the will to deal with it for a platform idgaf about ;). |
|
Right, I knew I'd also skipped over it on purpose in the past but I didn't remember why. |
benoit-pierre
force-pushed
the
pr/minimal_glib_static_build
branch
4 times, most recently
from
e1dd0e2 to
2a30afd
Compare
- compile only the part of gettext we need - compile only a static version of `libglib-2.0`, since that's all sdcv needs
benoit-pierre
force-pushed
the
pr/minimal_glib_static_build
branch
from
2a30afd to
3ed7ab2
Compare
|
@benoit-pierre What does the draft status currently indicate? ^_^ |
|
I was just waiting for #1689 to be merged. |
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 9, 2023
* Bump base includes: koreader/koreader-base#1691 koreader/koreader-base#1692 koreader/koreader-base#1689 koreader/koreader-base#1690 koreader/koreader-base#1693 * Integrate decoding of SSIDs within wpa_supplicant The UTF-8 decoding of SSIDs is specific to wpa_supplicant. In this patch, we move all of this decoding logic to the wpa_supplicant module. We expose the raw bytes of the SSID to the NetworkMgr code, and make sure to always fix bad UTF-8 before we display the SSID to the user. Within the wpa_supplicant module, we replace the call to the wpa_passphrase binary to get the PSK with a direct function call to OpenSSL. This allows us to calculate the PSK over any arbitrary bytes, including UTF-8. In the same vein, we use the hex-encoded SSID to communicate with wpa_supplicant when setting up the network to support arbitrary bytes in the SSID. Unfortunately, we also remove the tests, as there is no way to unit test local functions.
benoit-pierre
added a commit
to benoit-pierre/koreader-base
that referenced
this pull request
Mar 27, 2024
Not needed on other platforms, fix regression introduced in koreader#1690.
benoit-pierre
added a commit
to benoit-pierre/koreader-base
that referenced
this pull request
Mar 27, 2024
Not needed on other platforms, fix regression introduced in koreader#1690.
Frenzie
pushed a commit
that referenced
this pull request
Mar 31, 2024
Not needed on other platforms, fix regression introduced in #1690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libglib-2.0, since that's all sdcv needsThis change is