Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: allow drawing images inverted, various fixes #883

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Mar 29, 2019

Includes koreader/crengine#276:

  • DrawBuf: allow drawing images inverted (to be used in night mode)
  • ldomXPointer::getRect(): adds adjusted=false parameter
  • CSS: fix parsing of "! important" with spaces
  • CSS: fix non-deterministic combinators
  • Delay some style computations until needed Delay some style computations until needed crengine#278

Includes:
- DrawBuf: allow drawing images inverted (to be used in night mode)
- ldomXPointer::getRect(): adds adjusted=false parameter
- CSS: fix parsing of "! important" with spaces
- CSS: fix non-deterministic combinators
- Delay some style computations until needed
@poire-z
Copy link
Contributor Author

poire-z commented Mar 29, 2019

Some error at some point:

-- downloading...
     src='http://ftpmirror.gnu.org/tar/tar-1.32.tar.gz'
     dst='/home/ko/base/thirdparty/tar/build/downloads/tar-1.32.tar.gz'
     timeout='none'
CMake Error at tar-stamp/download-tar.cmake:27 (message):
  error: downloading 'http://ftpmirror.gnu.org/tar/tar-1.32.tar.gz' failed
    status_code: 7
    status_string: "Couldn't connect to server"
    log:   Trying 209.51.188.200...
    Trying 2001:470:142:5::200...
  Immediate connect fail for 2001:470:142:5::200: Cannot assign requested address

Some ipv6 mess ?! on gnu side or at travis?

Ignorable and i can merge? Or better to wait it gets resolved?

@Frenzie
Copy link
Member

Frenzie commented Mar 29, 2019

You can always restart them, but for something like this the non-unit test builds can be ignored fairly safely.

@poire-z
Copy link
Contributor Author

poire-z commented Mar 29, 2019

Restarted a few over the last hour, no luck...

@poire-z poire-z merged commit ed04819 into koreader:master Mar 29, 2019
@poire-z poire-z deleted the bump_crengine branch March 29, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants