-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added subchunking, but needs more improvements #16
Conversation
I still need to implement chunk IDs, instead of just adding delays between packages to ensure they are received in the correct order. |
The problem now is when the packets from the next image catch up with the packets from the previous image (or there is packet loss at the previous one) then the chunk IDs collide and it tries to store a chunk with the wrong size in the previous image and then it crashes. The solutions I see are the following:
The advantage is that this method handles packet loss much better and it just updates the image continuously.
|
(redone to remove unrelated changes)
9d980ed
to
78f18ff
Compare
…ich solution is best
…doesn't crash, but only shows a distorted portion of the screen.
Decided on going with solution 2 would be best, instead of simply delaying the issue of packetloss. |
This PR is a pain. I've been experiencing the one visual bug after the other, right now the visual is skewed when the size of the image is uneven. On top of this, I'm also experiencing problems with the removed compression, as the bandwidth required for sending full HD uncompressed even on loopback adapter requires an high amount of bandwidth: 1920 x 1080 x 3 color bytes x 8 (to convert to bits) = ~50 Megabits per frame. For 30 frames per second that's 1.5 Gbps. I still need to find a good way to calculate the need chunks for sending a frame |
…*just works* I guess that's it then. The code should be cleansed before merging, but otherwise it's ready to merge.
Should be working correctly now, just need to redo some of the code and remove some comments and debug messages. |
closes #5