fix: move category filed from annotations to labels

kubeagi · Apr 1, 2024 · 403c750 · 403c750
1 parent b80e4e4
commit 403c750
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/api/base/v1alpha1/application.go b/api/base/v1alpha1/application.go
@@ -22,8 +22,8 @@ const (
 	InputNode  = "Input"
 	OutputNode = "Output"
 
-	// AppCategoryAnnotationKey app category, like "recommend" or "recommend,chat,role-playing". Multiple types are separated by commas
-	AppCategoryAnnotationKey = Group + "/app-category"
+	// AppCategoryLabelKey app category, like "recommend" or "recommend,chat,role-playing". Multiple types are separated by commas
+	AppCategoryLabelKey = Group + "/app-category"
 
 	// AppPublicLabelKey will add to app which is public
 	AppPublicLabelKey = Group + "/app-is-public"

diff --git a/apiserver/pkg/application/application.go b/apiserver/pkg/application/application.go
@@ -44,7 +44,7 @@ import (
 
 func addCategory(app *v1alpha1.Application, category []*string) *v1alpha1.Application {
 	if len(category) == 0 {
-		delete(app.Annotations, v1alpha1.AppCategoryAnnotationKey)
+		delete(app.Labels, v1alpha1.AppCategoryLabelKey)
 		return app
 	}
 	if app.Annotations == nil {
@@ -54,7 +54,7 @@ func addCategory(app *v1alpha1.Application, category []*string) *v1alpha1.Applic
 	for i := range category {
 		c[i] = *category[i]
 	}
-	app.Annotations[v1alpha1.AppCategoryAnnotationKey] = strings.Join(c, ",")
+	app.Labels[v1alpha1.AppCategoryLabelKey] = strings.Join(c, ",")
 	return app
 }
 

diff --git a/apiserver/pkg/common/common.go b/apiserver/pkg/common/common.go
@@ -239,7 +239,7 @@ func TypedObjectReferenceToInput(ref generated.TypedObjectReference) generated.T
 
 func GetAppCategory(app *v1alpha1.Application) []*string {
 	category := make([]*string, 0)
-	categoryStr, ok := app.GetAnnotations()[v1alpha1.AppCategoryAnnotationKey]
+	categoryStr, ok := app.GetLabels()[v1alpha1.AppCategoryLabelKey]
 	if ok && len(categoryStr) > 0 {
 		for _, v := range strings.Split(categoryStr, ",") {
 			v := v

diff --git a/apiserver/pkg/common/common_filter.go b/apiserver/pkg/common/common_filter.go
@@ -89,7 +89,7 @@ func FilterApplicationByKeyword(keyword string) ResourceFilter {
 
 func FilterApplicationByCategory(category string) ResourceFilter {
 	return func(u client.Object) bool {
-		categoryStr, ok := u.GetAnnotations()[v1alpha1.AppCategoryAnnotationKey]
+		categoryStr, ok := u.GetLabels()[v1alpha1.AppCategoryLabelKey]
 		if !ok {
 			return false
 		}