Fix web terminal cursor issue (#6805)

Signed-off-by: Waleed Malik <[email protected]>
kubermatic · Sep 3, 2024 · 58186ff · 58186ff
1 parent 35dce88
commit 58186ff
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/modules/api/pkg/handler/websocket/terminal.go b/modules/api/pkg/handler/websocket/terminal.go
@@ -711,6 +711,8 @@ func Terminal(ctx context.Context, ws *websocket.Conn, client ctrlruntimeclient.
 			websocketConn: ws,
 			userEmailID:   userEmailID,
 			clusterClient: client,
+			sizeChan:      make(chan remotecommand.TerminalSize),
+			doneChan:      make(chan struct{}),
 		},
 		ws); err != nil {
 		log.Logger.Debug(err)

diff --git a/modules/web/src/app/shared/components/terminal/component.ts b/modules/web/src/app/shared/components/terminal/component.ts
@@ -206,6 +206,9 @@ export class TerminalComponent implements OnChanges, OnInit, OnDestroy, AfterVie
 
     const delayFn = debounce(() => {
       fitAddon.fit();
+      // Sync pty size on window resize
+      const dimensions = fitAddon.proposeDimensions();
+      this._resizePty(dimensions.cols, dimensions.rows);
     }, this.DELAY_TIMEOUT);
     delayFn();
 
@@ -334,4 +337,12 @@ export class TerminalComponent implements OnChanges, OnInit, OnDestroy, AfterVie
       Op: Operations.Refresh,
     });
   }
+
+  private _resizePty(cols: number, rows: number): void {
+    this._webTerminalSocketService.sendMessage({
+      Op: 'resize',
+      Cols: cols,
+      Rows: rows,
+    });
+  }
 }