Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML editor to configure CBSL config #6738

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add YAML editor to configure CBSL config #6738

merged 1 commit into from
Jul 18, 2024

Conversation

ahmadhamzh
Copy link
Contributor

What this PR does / why we need it:
add a yaml editor in the backup storage location dialog to configure the BSL config.

image

Which issue(s) this PR fixes:
Fixes #6732

What type of PR is this?
/kind feature

Add a `yaml` block field to add additional parameters to the `config` for the backup storage location 

NONE

@ahmadhamzh ahmadhamzh added kind/feature Categorizes issue or PR as related to a new feature. sig/ui Denotes a PR or issue as being assigned to SIG UI. labels Jul 18, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 147622d7ad8808130792a763a29279c3daadb082

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@kubermatic-bot kubermatic-bot merged commit 999cc91 into kubermatic:main Jul 18, 2024
8 of 10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/ui Denotes a PR or issue as being assigned to SIG UI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.26
Development

Successfully merging this pull request may close these issues.

User Cluster Backup Configuration for Minio Backend via KKP UI
3 participants
@ahmadhamzh @kubermatic-bot @ahmedwaleedmalik