-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add machine deployment metrics #1879
base: main
Are you sure you want to change the base?
feat(metrics): add machine deployment metrics #1879
Conversation
Signed-off-by: rajaSahil <[email protected]>
/assign @embik |
@rajaSahil did you see the linter errors? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: rajaSahil <[email protected]>
2cee2d6
to
1c8ac03
Compare
@embik Please re-review, have fixed lint errors. |
var StatusUpdateFailed = cloudprovidererrors.TerminalError{ | ||
Reason: common.UpdateMachineError, | ||
Message: "Failed to update the machine status", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this is something you did because of linting errors, can we please just quickly document (in this thread) why it's being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter threw this error pkg/cloudprovider/provider/anexia/types/types.go:45:5: the sentinel error name
StatusUpdateFailedshould conform to the
ErrXxx format (errname)
and it is not getting used anywhere that's why I removed it.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1767
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: