Merge pull request #2144 from cjihrig/ws-close

websocket: do not close when protocol supports it
kubernetes-client · Jan 8, 2025 · 42e5a7c · 42e5a7c
2 parents 47f1bf4 + 5de6593
commit 42e5a7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/web-socket-handler.ts b/src/web-socket-handler.ts
@@ -96,6 +96,7 @@ export class WebSocketHandler implements WebSocketInterface {
                 buff.writeUint8(this.CloseStream, 0);
                 buff.writeUint8(this.StdinStream, 1);
                 ws.send(buff);
+                return;
             }
             ws.close();
         });

diff --git a/src/web-socket-handler_test.ts b/src/web-socket-handler_test.ts
@@ -404,8 +404,10 @@ describe('V5 protocol support', () => {
             send: (data) => {
                 sent = data;
             },
-            close: () => {},
-        } as WebSocket;
+            close: () => {
+                throw new Error('should not be called');
+            },
+        } as unknown as WebSocket;
         const stdinStream = new ReadableStreamBuffer();
         WebSocketHandler.handleStandardInput(ws, stdinStream);
         stdinStream.emit('end');