-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on the external-snaphot-metadata sidecar (alpha). #605
base: master
Are you sure you want to change the base?
Documentation on the external-snaphot-metadata sidecar (alpha). #605
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the references to the KEP (like the CR, "Risks and Mitigations") could be included here directly, it'll be a much simpler read for the users.
b5fd8df
to
8c9996b
Compare
9fea794
to
4c157ba
Compare
3f3e5b0
to
b5a4524
Compare
The documentation has been updated to reflect the alpha version of v0.1.0. |
b5a4524
to
7a41ef4
Compare
7a41ef4
to
0d6ca24
Compare
@nixpanic @Rakshith-R Thanks for the feedback so far. I've reshuffled some material slightly by adding a "Resources" section to clearly identify programming artifacts available to application developers and CSI driver developers. I think it will make things much more obvious. I've also tried to be consistent with the naming, and reduce hyperlinks to just 1 per section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlbraganza, Rakshith-R The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.