Upgrade dependencies ahead of new external-provisioner release #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XXL
|
Hello Team |
|
@anchaube FYI this PR is blocked until new release of https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner |
|
/retest |
|
Forgot to update vendor dir now that new sig-storage-lib-external-provisioner released... One moment |
AndrewSirenko
force-pushed
the
dep-bump
branch
from
ec8c131 to
8ea8784
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Upgrade dependencies ahead of new external-provisioner release. Will fail for now until new sig-storage-lib-external-provisioner patch release. See special notes section.
Note that new version of csi-translation-lib supports contextual logging, but provisioner does not. Therefore I passed down a
klog.TODO()for now to unblock dep bump.Had to regenerate ProvisionerCSITranslator mock because of ^^. Used
mockgen -package controller -destination=./pkg/controller/fake_translator_test.go -source=./pkg/controller/controller.go ProvisionerCSITranslatorMight have to have replace directive for errdefs until
github.com/google/cadvisorupgrades to errdefs v1.0.0. Will try to see if Go complains if we import both v0.1.0 and v1.0.0 once the lib gets a new patch version.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Passes
make; make testlocally if I include replace directivereplace sigs.k8s.io/sig-storage-lib-external-provisioner/v11 => ../sig-storage-lib-external-provisionerto incorporate kubernetes-sigs/sig-storage-lib-external-provisioner#182It will fail CI for now.
/hold
Holding until https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/182s merged
Does this PR introduce a user-facing change?: