Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-8.1] Bump to go v1.23.1 to fix trivy #1244

Merged
merged 4 commits into from
Dec 11, 2024
Merged

[release-8.1] Bump to go v1.23.1 to fix trivy #1244

merged 4 commits into from
Dec 11, 2024

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Dec 10, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

#1242 fails due to Trivy detecting CVEs in go v1.22.5. Release-8.0 does not have these CVEs because they do not exist in go v1.22.3.

This PR:

Squashed 'release-tools/' changes from 988496a1..406a79ac

    Squashed 'release-tools/' changes from 988496a1..406a79ac

    Squashed 'release-tools/' changes from 988496a1..406a79ac

    406a79ac Merge pull request #267 from huww98/gomodcache
    9cec273d Set GOMODCACHE to avoid re-download toolchain
    98f23071 Merge pull request #260 from TerryHowe/update-csi-driver-version
    e9d8712d Merge pull request #259 from stmcginnis/deprecated-kind-kube-root
    faf79ff6 Remove --kube-root deprecated kind argument
    734c2b95 Merge pull request #265 from Rakshith-R/consider-main-branch
    f95c855b Merge pull request #262 from huww98/golang-toolchain
    3c8d966f Treat main branch as equivalent to master branch
    e31de525 Merge pull request #261 from huww98/golang
    fd153a9e Bump golang to 1.23.1
    a8b3d050 pull-test.sh: fix "git subtree pull" errors
    6b05f0fc use new GOTOOLCHAIN env to manage go version
    18b6ac6d chore: update CSI driver version to 1.15
    227577e0 Merge pull request #258 from gnufied/enable-race-detection
    e1ceee28 Always enable race detection while running tests

    git-subtree-dir: release-tools
    git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@AndrewSirenko
Copy link
Contributor Author

/CC @huww98

Is cherry-picking your #1208 needed in this PR? Or are we fine because we're just fixing a CVE on a patch release.

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: GitHub didn't allow me to request PR reviews from the following users: huww98.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/CC @huww98

Is cherry-picking your #1208 needed in this PR? Or are we fine because we're just fixing a CVE on a patch release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2024
@AndrewSirenko AndrewSirenko mentioned this pull request Dec 10, 2024
Merged
@AndrewSirenko
Copy link
Contributor Author

Data race, perhaps fixed by client_golang bump in #1180. Will iterate locally.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
@AndrewSirenko
Copy link
Contributor Author

/retest

Failure looks like a flake due to test cluster?

@AndrewSirenko
Copy link
Contributor Author

/test pull-kubernetes-csi-external-snapshotter-1-28-on-kubernetes-1-28

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-1-29
  • /test pull-kubernetes-csi-external-snapshotter-1-30-on-kubernetes-1-30
  • /test pull-kubernetes-csi-external-snapshotter-unit

The following commands are available to trigger optional jobs:

  • /test pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-1-30-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-1-31-on-kubernetes-1-31
  • /test pull-kubernetes-csi-external-snapshotter-1-31-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-alpha-1-30-on-kubernetes-1-30
  • /test pull-kubernetes-csi-external-snapshotter-canary

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubernetes-csi-external-snapshotter-1-29-on-kubernetes-1-29
  • pull-kubernetes-csi-external-snapshotter-1-30-on-kubernetes-1-30
  • pull-kubernetes-csi-external-snapshotter-1-31-on-kubernetes-1-31
  • pull-kubernetes-csi-external-snapshotter-unit

In response to this:

/test pull-kubernetes-csi-external-snapshotter-1-28-on-kubernetes-1-28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AndrewSirenko
Copy link
Contributor Author

AndrewSirenko commented Dec 10, 2024 •
edited
Loading

Test should be fixed with kubernetes-csi/csi-release-tools#267

Will rebase PR once that is merged.

@AndrewSirenko
Bump prometheus/client_golang to fix data race
39d0328
@AndrewSirenko
Squashed 'release-tools/' changes from 988496a1..406a79ac
e2595d3 
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
@AndrewSirenko
Merge commit 'e2595d3fd45180e50cedd44318b13d5ddb6948fa' into cve-cher…
9a97999 
…rypicks
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 59af672 into kubernetes-csi:release-8.1 Dec 11, 2024
8 checks passed
@AndrewSirenko AndrewSirenko mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewSirenko @k8s-ci-robot @xing-yang @andyzhangx