Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release tools with go version fix #248

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Update release tools with go version fix #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd505f
Squashed 'release-tools/' changes from b54c1ba..dc4d0ae
RaunakShah Feb 23, 2024
61d4fb9
Merge commit '1fd505f9017d6061e1b40e4f68a26114437ecd17' into release-…
RaunakShah Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion release-tools/prow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,15 @@ go_version_for_kubernetes () (
local version="$2"
local go_version

# We use the minimal Go version specified for each K8S release (= minimum_go_version in hack/lib/golang.sh).
# Try to get the version for .go-version
go_version="$( cat "$path/.go-version" )"
if [ "$go_version" ]; then
echo "$go_version"
return
fi

# Fall back to hack/lib/golang.sh parsing.
# This is necessary in v1.26.0 and older Kubernetes releases that do not have .go-version.
# More recent versions might also work, but we don't want to count on that.
go_version="$(grep minimum_go_version= "$path/hack/lib/golang.sh" | sed -e 's/.*=go//')"
if ! [ "$go_version" ]; then
Expand Down