Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kong plugins feature #72

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Kong plugins feature #72

merged 3 commits into from
Oct 23, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Oct 11, 2023 •
edited by LiorLieberman
Loading

What type of PR is this?

What this PR does / why we need it:

Kong plugins feature. The konhq.com/plugins ingress annotation is converted to a list of ExtensionRef filters.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

[Kong Provider] Add support for converting the `konghq.com/plugins` ingress annotation to a list of `ExtensionRef` HTTPRoute filters.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2023
@mlavacca mlavacca temporarily deployed to release October 11, 2023 15:00 — with GitHub Actions Inactive
levikobi
levikobi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another great contribution @mlavacca!
Just a small NIT, other than that lgtm

pkg/i2gw/providers/kong/plugins.go Outdated Show resolved Hide resolved
@mlavacca
feat: Kong plugins feature
39fe815 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-plugins-feature branch from 583a97d to ff4f792 Compare October 18, 2023 12:12
@mlavacca mlavacca temporarily deployed to release October 18, 2023 12:13 — with GitHub Actions Inactive
@mlavacca
feat: Kong README.md updated
a0bca0b 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-plugins-feature branch from ff4f792 to a0bca0b Compare October 19, 2023 10:07
@mlavacca mlavacca temporarily deployed to release October 19, 2023 10:07 — with GitHub Actions Inactive
@mlavacca
Copy link
Member Author

mlavacca commented Oct 20, 2023 •
edited
Loading

/assign @robscott

@mlavacca
Copy link
Member Author

/assign @LiorLieberman

@mlavacca mlavacca temporarily deployed to release October 20, 2023 15:46 — with GitHub Actions Inactive
levikobi
levikobi reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2023
@mlavacca
address review's comments
7452b69 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the kong-plugins-feature branch from a5d11a9 to 7452b69 Compare October 23, 2023 07:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@mlavacca mlavacca temporarily deployed to release October 23, 2023 07:51 — with GitHub Actions Inactive
@levikobi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@LiorLieberman
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: levikobi, LiorLieberman, mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit b2b165e into kubernetes-sigs:main Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman left review comments

@levikobi levikobi levikobi approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@robscott robscott

@levikobi levikobi

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlavacca @levikobi @LiorLieberman @k8s-ci-robot @robscott