Fix building aarch64 linux wheel #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
|
Right on, thanks for knocking this out so quickly! |
|
@kylebarron is it possible to also publish for |
|
No, it doesn't compile on 2_17: https://github.com/kylebarron/arro3/actions/runs/12416815454/job/34666333514, #278. You're welcome to make a PR to try and fix that compilation |
|
Ah bummer! I'll take a look and try to figure something out. Thanks for pointing me to the failing build |
|
It looks like 2_24 works, it's just 2_17 that doesn't, see #279 |
|
@kylebarron I managed to figure out a workaround in Nix. I can manually override the derivation builder for each dependency so don't need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276.
The core issue is that ring (used by rustls) doesn't build automatically (at least with manylinux auto) for linux aarch64.
This PR changes the manylinux version for aarch64 to be manylinux_2_28.
Ref PyO3/maturin-action#278, PyO3/maturin-action#222