Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Blocking SSH access for all provisioned and upgraded Kyma runtimes #3457

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix Blocking SSH access for all provisioned and upgraded Kyma runtimes #3457

merged 2 commits into from
Jul 3, 2024

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Jul 3, 2024 •
edited
Loading

What this PR does : Setting the parameter shoot.Spec.Provider.WorkersSettings.SSHAccess to false for all provisioned and updated Gardener Shoots resources to block SSH traffic.

Related Issue: someGHRepo/kyma/backlog/issues/5775

Why this PR is created: Requested by SRE to address SSH security vulnerability. Check the linked issue for more details.

Includes all required unit tests adjustments.

@koala7659 koala7659 requested a review from a team as a code owner July 3, 2024 12:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@koala7659 koala7659 changed the title Blocking SSH access to provisioned Gardener clusters Blocking SSH access for all provisioned and upgraded Gardener clusters Jul 3, 2024
@koala7659 koala7659 changed the title Blocking SSH access for all provisioned and upgraded Gardener clusters Blocking SSH access for all provisioned and upgraded Kyma runtimes Jul 3, 2024
@koala7659 koala7659 changed the title Blocking SSH access for all provisioned and upgraded Kyma runtimes Bugfix Blocking SSH access for all provisioned and upgraded Kyma runtimes Jul 3, 2024
@koala7659 koala7659 changed the title Bugfix Blocking SSH access for all provisioned and upgraded Kyma runtimes fix Blocking SSH access for all provisioned and upgraded Kyma runtimes Jul 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@koala7659 koala7659 added area/security Issues or PRs related to security priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 3, 2024
Disper
Disper approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The test cluster has the expected configuration:

workersSettings:
  sshAccess:
    enabled: false

@kyma-bot kyma-bot merged commit 110e15f into kyma-project:main Jul 3, 2024
6 checks passed
koala7659 added a commit to koala7659/control-plane that referenced this pull request Jul 3, 2024
@koala7659
update provisioner image to version v20240703-110e15f7 after the merg…
1ca1b07 
…e of kyma-project#3457
@koala7659 koala7659 mentioned this pull request Jul 3, 2024
Merged
kyma-bot pushed a commit that referenced this pull request Jul 4, 2024
@koala7659
update provisioner image to version v20240703-110e15f7 after the merg…
9330008 
…e of #3457 (#3458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebensom ebensom ebensom approved these changes

@Disper Disper Disper approved these changes

Assignees

@Disper Disper

@ebensom ebensom

Labels
area/security Issues or PRs related to security cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koala7659 @Disper @ebensom @kyma-bot