Merge branch 'fix-13'

exportloopref.go

@@ -298,6 +298,9 @@ func (s *Searcher) isVar(loop ast.Node, expr ast.Expr) bool {
 	}
 	switch typed := expr.(type) {
 	case (*ast.Ident):
+		if typed.Obj == nil {
+			return false // global var in another file (ref: #13)
+		}
 		_, isVar := vars[typed.Obj.Pos()]
 		return isVar
 	case (*ast.IndexExpr): // like X[Y], check X

exportloopref_test.go

@@ -46,3 +46,8 @@ func TestDepPointer(t *testing.T) {
 	testdata := analysistest.TestData()
 	analysistest.Run(t, testdata, exportloopref.Analyzer, "deeppointer")
 }
+
+func TestReRef(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, exportloopref.Analyzer, "reref")
+}

testdata/src/reref/another_file.go

@@ -0,0 +1,4 @@
+package main
+
+// Moving this map to main.go fixes nil pointer deference
+var globalMapInDifferentFile = map[int]*MyStruct{}

testdata/src/reref/issue13.go

@@ -0,0 +1,13 @@
+package main
+
+type MyStruct struct {
+	MyStructPtrField *int
+}
+
+func main() {
+	localVal := 0
+	arr := []MyStruct{{&localVal}}
+	for _, p := range arr {
+		t := *p.MyStructPtrField
+		globalMapInDifferentFile[t] = &p // want "exporting a pointer for the loop variable p"
+	}