-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Configurable Threshold Values via config.json #24
Merged
KhaledEmaraDev
merged 10 commits into
kyverno:main
from
jigar-joshi-nirmata:configurable-threshold-value
Jan 15, 2025
Merged
Feature: Configurable Threshold Values via config.json #24
KhaledEmaraDev
merged 10 commits into
kyverno:main
from
jigar-joshi-nirmata:configurable-threshold-value
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jigar-joshi-nirmata
changed the title
Configurable threshold value
Feature: Configurable Threshold Values via config.json
Jan 15, 2025
…t customization Signed-off-by: Jigar Joshi <[email protected]>
…verno-pss.js Signed-off-by: Jigar Joshi <[email protected]>
Signed-off-by: Jigar Joshi <[email protected]>
Signed-off-by: Jigar Joshi <[email protected]>
Signed-off-by: Jigar Joshi <[email protected]>
…t have package.json file Signed-off-by: Jigar Joshi <[email protected]>
…h very small threshold vallues Signed-off-by: Jigar Joshi <[email protected]>
…ures with very small threshold vallues" This reverts commit 4767e79. Signed-off-by: Jigar Joshi <[email protected]>
Signed-off-by: Jigar Joshi <[email protected]>
Signed-off-by: Jigar Joshi <[email protected]>
jigar-joshi-nirmata
force-pushed
the
configurable-threshold-value
branch
from
January 15, 2025 09:38
12b9481
to
0c2a485
Compare
KhaledEmaraDev
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This feature introduces dynamic configurability for test thresholds used in the testing framework. Threshold values can now be set through environment variables, providing flexibility for various testing environments. If no environment variables are provided, the system uses predefined default values to ensure compatibility and ease of use.
Key Features
Default Threshold Values
The following default values are applied when no environment variables are set:
Example
To customize the duration for
average
tests:Run the tests, and the custom value will be applied.
Using Environment Variables in Workflows
In workflows, you can pass environment variables using the
-e
flag. For example:This ensures that custom values are applied dynamically during the test execution.
This feature enhances both flexibility and usability while preserving the stability of existing workflows.