Add support for elasticSearch typeless API #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guipal <[email protected]>
guipal
force-pushed
the
fix/fix-elasticSearch-target-integration
branch
from
c821e0f to
bfadc55
Compare
|
Hello fjogeleit another minor change for elasticSearch compatibility. Not bumping helm chart just in case you wanna include something else. Thankyou! |
|
Hey @guipal, thanks for the contribution. I will check and the missing bump is fine. |
fjogeleit
reviewed
Jan 8, 2024
| @@ -30,13 +30,14 @@ elasticsearch: | |||
| skipTLS: {{ .Values.target.elasticsearch.skipTLS }} | |||
| username: {{ .Values.target.elasticsearch.username | quote }} | |||
| password: {{ .Values.target.elasticsearch.password | quote }} | |||
| apiKey: {{ .Values.target.elasticsearch.password | quote }} | |||
| apiKey: {{ .Values.target.elasticsearch.apiKey | quote }} | |||
fjogeleit
reviewed
Jan 8, 2024
| @@ -76,12 +88,16 @@ func (e *client) Send(result v1alpha2.PolicyReportResult) { | |||
| return | |||
| } | |||
|
|
|||
| zap.L().Info("ElasticSearch ApiKey" + e.apiKey) | |||
There was a problem hiding this comment.
I think this was for debugging and should be removed now
fjogeleit
reviewed
Jan 8, 2024
| if e.username != "" { | ||
| req.SetBasicAuth(e.username, e.password) | ||
| } else if e.apiKey != "" { | ||
| req.Header.Add("Authorization", "ApiKey "+e.apiKey) | ||
| } | ||
|
|
||
| zap.L().Info("ElasticSearch Authorization Header" + req.Header.Get("Authorization")) |
Signed-off-by: guipal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for elastic search typeless API
Problem
As described in elastic docs. Starting from elastic version 8.0 APIs that accept types are removed and a new endpoint needs to be called.
Proposed Solution
Introduce a new configuration variable to enable usage of new endpoint to send data when using ES>8.0