Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying SOLID and CLEAN CODE #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AmandaMuniz
Copy link
Collaborator

While refactoring the backend files two steps were made. The first one was to identify where exists the necessity to modify the code, to respect the solid principles, and made these changes. The second one was to apply clean code. Because of this, the following changes were made:

  1. The file entity.py was empty, and therefore removed from the project;
  2. The models Intent and Utter had a function called to_representation that was repeated and commented, therefore was deleted;
  3. The file parser was refactored using clean code methods.

@AmandaMuniz AmandaMuniz self-assigned this Apr 22, 2021
@AmandaMuniz
Copy link
Collaborator Author

This pull request resolves the following issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant