for svycoxph use default

fix #275
larmarange · Sep 26, 2024 · 4cb9d59 · 4cb9d59
1 parent de429ec
commit 4cb9d59
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 1 deletion.
diff --git a/NAMESPACE b/NAMESPACE
@@ -36,6 +36,7 @@ S3method(model_get_model_frame,default)
 S3method(model_get_model_frame,fixest)
 S3method(model_get_model_frame,model_fit)
 S3method(model_get_model_frame,survreg)
+S3method(model_get_model_frame,svycoxph)
 S3method(model_get_model_matrix,LORgee)
 S3method(model_get_model_matrix,betareg)
 S3method(model_get_model_matrix,biglm)

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # broom.helpers (development version)
 
+**Fixes**
+
+- variable labels are now returned by `model_list_variables()` for `svycoxph`
+  models (#275)
+
 # broom.helpers 1.17.0
 
 **Deprecated functions and changes in selectors functions**

diff --git a/R/model_get_model_frame.R b/R/model_get_model_frame.R
@@ -56,6 +56,10 @@ model_get_model_frame.coxph <- function(model) {
   res
 }
 
+#' @export
+#' @rdname model_get_model_frame
+model_get_model_frame.svycoxph <- model_get_model_frame.default
+
 #' @export
 #' @rdname model_get_model_frame
 model_get_model_frame.survreg <- function(model) {

diff --git a/man/model_get_model_frame.Rd b/man/model_get_model_frame.Rd
diff --git a/tests/testthat/test-tidy_plus_plus.R b/tests/testthat/test-tidy_plus_plus.R
@@ -331,7 +331,10 @@ test_that("tidy_plus_plus() works with survey::svyglm", {
 test_that("tidy_plus_plus() works with survey::svycoxph", {
   skip_on_cran()
   skip_if_not_installed("survey")
-  dpbc <- survey::svydesign(id = ~1, prob = ~1, strata = ~edema, data = survival::pbc)
+  skip_if_not_installed("labelled")
+  d <- survival::pbc
+  labelled::var_label(d$albumin) <- "Custom label"
+  dpbc <- survey::svydesign(id = ~1, prob = ~1, strata = ~edema, data = d)
   mod <- survey::svycoxph(
     Surv(time, status > 0) ~ log(bili) + protime + albumin,
     design = dpbc
@@ -340,6 +343,10 @@ test_that("tidy_plus_plus() works with survey::svycoxph", {
     res <- mod |> tidy_plus_plus(),
     NA
   )
+  expect_equivalent(
+    res[res$term == "albumin", "var_label"][[1]][1],
+    "Custom label"
+  )
 })
 
 test_that("tidy_plus_plus() works with survey::svyolr", {