compatibility with R 4.1

larmarange · Oct 7, 2024 · 5089e29 · 5089e29
1 parent 6998226
commit 5089e29
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 43 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -15,7 +15,7 @@ License: GPL (>= 3)
 URL: https://larmarange.github.io/broom.helpers/, https://github.com/larmarange/broom.helpers
 BugReports: https://github.com/larmarange/broom.helpers/issues
 Depends:
-    R (>= 4.2)
+    R (>= 4.1)
 Imports: 
     broom (>= 0.8),
     cards,

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,7 @@
 
 - variable labels are now returned by `model_list_variables()` for `svycoxph`
   models (#275)
+- compatibility with R version 4.1 minimum (#276)
 
 # broom.helpers 1.17.0
 

diff --git a/R/model_identify_variables.R b/R/model_identify_variables.R
@@ -26,12 +26,11 @@
 #' ) |>
 #'   model_identify_variables()
 #'
-#' iris |>
-#'   lm(
-#'     Sepal.Length ~ poly(Sepal.Width, 2) + Species,
-#'     data = _,
-#'     contrasts = list(Species = contr.sum)
-#'   ) |>
+#' lm(
+#'   Sepal.Length ~ poly(Sepal.Width, 2) + Species,
+#'   data = iris,
+#'   contrasts = list(Species = contr.sum)
+#' ) |>
 #'   model_identify_variables()
 model_identify_variables <- function(model) {
   UseMethod("model_identify_variables")

diff --git a/R/model_list_variables.R b/R/model_list_variables.R
@@ -40,20 +40,19 @@
 #'   ) |>
 #'   model_list_variables()
 #'
-#'   iris |>
-#'     lm(
-#'       Sepal.Length ~ poly(Sepal.Width, 2) + Species,
-#'       data = _,
-#'       contrasts = list(Species = contr.sum)
-#'     ) |>
-#'     model_list_variables()
-#'
-#'   glm(
-#'     response ~ poly(age, 3) + stage + grade * trt,
-#'     na.omit(gtsummary::trial),
-#'     family = binomial,
+#' lm(
+#'    Sepal.Length ~ poly(Sepal.Width, 2) + Species,
+#'    data = iris,
+#'    contrasts = list(Species = contr.sum)
 #'   ) |>
-#'     model_list_variables()
+#'   model_list_variables()
+#'
+#' glm(
+#'   response ~ poly(age, 3) + stage + grade * trt,
+#'   na.omit(gtsummary::trial),
+#'   family = binomial,
+#' ) |>
+#'   model_list_variables()
 #' }
 model_list_variables <- function(model, labels = NULL,
                                  only_variable = FALSE, add_var_type = FALSE) {

diff --git a/man/model_identify_variables.Rd b/man/model_identify_variables.Rd
diff --git a/man/model_list_variables.Rd b/man/model_list_variables.Rd
diff --git a/tests/testthat/test-add_term_labels.R b/tests/testthat/test-add_term_labels.R
@@ -254,11 +254,10 @@ test_that("tidy_add_term_labels() works with variables having non standard name"
     )
   )
 
-  res <- gtsummary::trial |>
-    dplyr::select(response, `age at dx` = age, `drug type` = trt) |>
-    lm(
+  res <- lm(
       response ~ `age at dx` + `drug type`,
-      data = _
+      data = gtsummary::trial |>
+        dplyr::select(response, `age at dx` = age, `drug type` = trt)
     ) |>
     tidy_and_attach() |>
     tidy_add_variable_labels(list(`age at dx` = "AGGGGGGGE")) |>