[p2app] Fix concurrency, undefined behavior, and UDP underflow + minor performance improvements#10

Closed

dchristle wants to merge 20 commits intolaurencebarker:mainfrom dchristle:dchristle/p2_glob_mem_barriers

+1,665-1,635

Commits on Nov 7, 2024

Change booleans shared amongst threads to atomic_bool.
dchristle
committed
Use mutex instead of binary semaphore.
dchristle
committed
Use poll for shutdown check.
dchristle
committed
Fix unaligned loads/stores in various places (e.g. InHighPriority) with memcpy.
dchristle
committed
Add additional mutexes and fix variable sizes.
dchristle
committed
Fix undefined behavior pointer alignment in HandleGeneralPacket.
dchristle
committed
Use pread instead of separate lseek + read calls to reduce syscalls and simplify.
dchristle
committed
* Increase usleep times to reduce syscall overhead.
dchristle
committed
Fix buffer underflow in msg_namelen, caused by using sizeof on an array of sockaddr_in instead of sizeof(sockaddr_in). Remove debug statements.
dchristle
committed
Remove extraneous FIFO check and add a small delay before the first read.
dchristle
committed
Make AnalyseDDCHeader more succint, inline, and mark the count array as static. Add a check to prevent an array out-of-bounds access bug for an interleaved DDC with integer near the end of the range.
dchristle
committed
Use ARMv8 SIMD instructions for IncomingDUCIQ load/swap/store loop on NEON-enabled platforms.
dchristle
committed
Formatting & cleanup unused variables.
dchristle
committed
Reduce work done inside the mutex for GetP2PTTKeyInputs. The last check for VCWKEYDOWN is redundant with the second one, so I've removed it.
dchristle
committed
Change more global variables to atomics to ensure cross-thread synchronization. Move the direct register operations out of version.c and into saturnregisters.c, for better encapsulation. Use facade…
dchristle
committed
Move register access for temperature fetch into saturnregisters & ensure
dchristle
committed
Fix clock info & ensure register access is guarded by mutex.
dchristle
committed
Revert timings and some formatting changes.
dchristle
committed
Avoid writing over by 4 bytes on the last iteration of transferIQSamples_SIMD. Handle the edge case if VIQSAMPLESPERFRAME is ever odd, or 1.
dchristle
committed
Combine duplicate logic in InDUCIQ.
dchristle
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[p2app] Fix concurrency, undefined behavior, and UDP underflow + minor performance improvements#10

Commits on Nov 7, 2024

Change booleans shared amongst threads to atomic_bool.

Use mutex instead of binary semaphore.

Use poll for shutdown check.

Fix unaligned loads/stores in various places (e.g. InHighPriority) with memcpy.

Add additional mutexes and fix variable sizes.

Fix undefined behavior pointer alignment in HandleGeneralPacket.

Use pread instead of separate lseek + read calls to reduce syscalls and simplify.

* Increase usleep times to reduce syscall overhead.

Fix buffer underflow in msg_namelen, caused by using sizeof on an array of sockaddr_in instead of sizeof(sockaddr_in). Remove debug statements.

Remove extraneous FIFO check and add a small delay before the first read.

Make AnalyseDDCHeader more succint, inline, and mark the count array as static. Add a check to prevent an array out-of-bounds access bug for an interleaved DDC with integer near the end of the range.

Use ARMv8 SIMD instructions for IncomingDUCIQ load/swap/store loop on NEON-enabled platforms.

Formatting & cleanup unused variables.

Reduce work done inside the mutex for GetP2PTTKeyInputs. The last check for VCWKEYDOWN is redundant with the second one, so I've removed it.

Change more global variables to atomics to ensure cross-thread synchronization. Move the direct register operations out of version.c and into saturnregisters.c, for better encapsulation. Use facade…

Move register access for temperature fetch into saturnregisters & ensure

Fix clock info & ensure register access is guarded by mutex.

Revert timings and some formatting changes.

Avoid writing over by 4 bytes on the last iteration of transferIQSamples_SIMD. Handle the edge case if VIQSAMPLESPERFRAME is ever odd, or 1.

Combine duplicate logic in InDUCIQ.