Merge pull request #2429 from leancodepl/pass-config-to-patrol_log

Pass config to patrol_log
leancodepl · Nov 22, 2024 · 0bf04f2 · 0bf04f2
2 parents 952f225 + e599642
commit 0bf04f2
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 30 deletions.
diff --git a/docs/compatibility-table.mdx b/docs/compatibility-table.mdx
@@ -13,7 +13,8 @@ the table below to assess which version you should use.
 
 |   patrol_cli   |     patrol     | Min Flutter Version |
 | -------------- | -------------- | ------------------- |
-| 3.3.0+         | 3.12.0+        | 3.24.0              |
+| 3.4.0+         | 3.13.0+        | 3.24.0              |
+| 3.3.0          | 3.12.0         | 3.24.0              |
 | 3.2.1          | 3.11.2         | 3.24.0              |
 | 3.2.0          | 3.11.0 - 3.11.1| 3.22.0              |
 | 3.1.0 - 3.1.1  | 3.10.0         | 3.22.0              |

diff --git a/packages/patrol/CHANGELOG.md b/packages/patrol/CHANGELOG.md
@@ -1,20 +1,11 @@
-## 3.13.0-dev.4
-
-- Bump `patrol_finders` and `patrol_log`
-
-## 3.13.0-dev.3
+## 3.13.0
 
+- Add support for the `patrol_log` package. (#2387)
+- Fix tapping on notification on iOS 18. (#2394)
 - Fix macos functionality. (#2408)
 - Bump `patrol_finders` and enable logging.
 
-## 3.13.0-dev.2
-
-- Bump `patrol_log` version.
-
-## 3.13.0-dev.1
-
-- Add support for the patrol_log package. (#2387)
-- Fix tapping on notification on iOS 18. (#2394)
+This version requires version 3.4.0 of `patrol_cli` package.
 
 ## 3.12.0
 

diff --git a/packages/patrol/lib/src/common.dart b/packages/patrol/lib/src/common.dart
@@ -97,7 +97,7 @@ void patrolTest(
   LiveTestWidgetsFlutterBindingFramePolicy framePolicy =
       LiveTestWidgetsFlutterBindingFramePolicy.fadePointers,
 }) {
-  final patrolLog = PatrolLogWriter();
+  final patrolLog = PatrolLogWriter(config: {'printLogs': config.printLogs});
   final automator = NativeAutomator(config: nativeAutomatorConfig);
   final automator2 = NativeAutomator2(config: nativeAutomatorConfig);
   final patrolBinding = PatrolBinding.ensureInitialized(nativeAutomatorConfig)

diff --git a/packages/patrol/pubspec.yaml b/packages/patrol/pubspec.yaml
@@ -2,7 +2,7 @@ name: patrol
 description: >
   Powerful Flutter-native UI testing framework overcoming limitations of
   existing Flutter testing tools. Ready for action!
-version: 3.13.0-dev.4
+version: 3.13.0
 homepage: https://patrol.leancode.co
 repository: https://github.com/leancodepl/patrol/tree/master/packages/patrol
 issue_tracker: https://github.com/leancodepl/patrol/issues
@@ -26,8 +26,8 @@ dependencies:
   http: '^1.1.0'
   json_annotation: ^4.8.1
   meta: ^1.10.0
-  patrol_finders: ^2.4.0
-  patrol_log: ^0.1.0
+  patrol_finders: ^2.4.1
+  patrol_log: ^0.2.0
   shelf: ^1.4.1
   test_api: '^0.7.0'
 

diff --git a/packages/patrol_cli/CHANGELOG.md b/packages/patrol_cli/CHANGELOG.md
@@ -1,14 +1,8 @@
-## 3.4.0-dev.3
+## 3.4.0
 
-- Add flag `clear-test-steps`. (#2421)
+- Add support for the `patrol_log` package. (#2387)
 
-## 3.4.0-dev.2
-
-- Bump `patrol_log` version. (#2402)
-
-## 3.4.0-dev.1
-
-- Add support for the patrol_log package. (#2387)
+This version requires version 3.13.0 of `patrol` package.
 
 ## 3.3.0
 

diff --git a/packages/patrol_cli/lib/src/base/constants.dart b/packages/patrol_cli/lib/src/base/constants.dart
@@ -1,3 +1,3 @@
 /// Version of Patrol CLI. Must be kept in sync with pubspec.yaml.
 /// If you update this, make sure that compatibility-table.mdx is updated (if needed)
-const version = '3.4.0-dev.3';
+const version = '3.4.0';
diff --git a/packages/patrol_cli/lib/src/compatibility_checker/compatibility_checker.dart b/packages/patrol_cli/lib/src/compatibility_checker/compatibility_checker.dart
@@ -211,6 +211,10 @@ final _patrolVersionRange = [
   ),
   VersionRange(
     min: Version.parse('3.12.0'),
+    max: Version.parse('3.12.0'),
+  ),
+  VersionRange(
+    min: Version.parse('3.13.0'),
   ),
 ];
 
@@ -257,5 +261,9 @@ final _patrolCliVersionRange = [
   ),
   VersionRange(
     min: Version.parse('3.3.0'),
+    max: Version.parse('3.3.0'),
+  ),
+  VersionRange(
+    min: Version.parse('3.4.0'),
   ),
 ];
diff --git a/packages/patrol_cli/lib/src/pubspec_reader.dart b/packages/patrol_cli/lib/src/pubspec_reader.dart
@@ -1,3 +1,6 @@
+// TODO: manage immutable classes
+// ignore_for_file: must_be_immutable
+
 import 'package:equatable/equatable.dart';
 import 'package:file/file.dart';
 import 'package:yaml/yaml.dart';

diff --git a/packages/patrol_cli/pubspec.yaml b/packages/patrol_cli/pubspec.yaml
@@ -1,7 +1,7 @@
 name: patrol_cli
 description: >
   Command-line tool for Patrol, a powerful Flutter-native UI testing framework.
-version: 3.4.0-dev.3  # Must be kept in sync with constants.dart
+version: 3.4.0  # Must be kept in sync with constants.dart
 homepage: https://patrol.leancode.co
 repository: https://github.com/leancodepl/patrol/tree/master/packages/patrol_cli
 issue_tracker: https://github.com/leancodepl/patrol/issues?q=is%3Aopen+is%3Aissue+label%3A%22package%3A+patrol_cli%22
@@ -30,7 +30,7 @@ dependencies:
   mason_logger: ^0.2.10
   meta: ^1.10.0
   path: ^1.8.3
-  patrol_log: ^0.1.0
+  patrol_log: ^0.2.0
   platform: ^3.1.3
   process: ^5.0.1
   pub_updater: ^0.4.0