Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix masking #25

Merged
merged 16 commits into from
Jul 12, 2024
Merged

Fix masking #25

merged 16 commits into from
Jul 12, 2024

Conversation

dugalh
Copy link
Collaborator

@dugalh dugalh commented Jul 12, 2024

Fixes

dugalh added 16 commits July 3, 2024 19:30
@dugalh
cloud mask full image in S2 images with no QA60 or cloud probability …
867e70d 
…data (#24)
@dugalh
update rio pin for nodata=-inf compatibility
12b2e10
@dugalh
change float* nodata value to -inf
ce8df7a
@dugalh
leave float* nodata on EE default (-inf)
5908932
@dugalh
specify _set_region_stats scale for problem images
7d86a34
@dugalh
add test for EE GeoTIFF nodata value
b5bfd5b
@dugalh
simplify get_projection
dbc8fa4
@dugalh
add fixtures for S2 images missing QA/cloud data
c67afe8
@dugalh
Add and improve S2 cloud masking tests
ecc6618 
Adjust existing tests to test both S2 cloud mask methods.
Test new _ee_proj property and add tests for masking S2 images with missing data.
@dugalh
Refactor stats and aux band projections.
89cd969 
Add _ee_proj property with overrides to simplify scale / reprojection, and
avoid issues with non-fixed projection bands.
@dugalh
update nodata test for EE's -inf
210e866
@dugalh
refine tests and fixtures for missing cloud data
a19ce87
@dugalh
mask aux bands for images missing cloud data
69975aa
@dugalh
format updates
98081e5
@dugalh
change and add tests for masking with missing cloud data
d5b3032
@dugalh
add to do
7fc00ed
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (1bf7cbd) to head (7fc00ed).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   91.69%   91.73%   +0.04%     
==========================================
  Files          13       13              
  Lines        1613     1622       +9     
==========================================
+ Hits         1479     1488       +9     
  Misses        134      134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dugalh dugalh merged commit d8650f4 into main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentinel-2 masking fails when missing cloud data.
1 participant
@dugalh