Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DELETE /users/:id/subscriptions/:id endpoint #530

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

chenhunghan
Copy link
Collaborator

The endpoint should not be in used, and will be removed when https://github.com/lensapp/lenscloud/pull/3824 is merged.

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
@chenhunghan chenhunghan changed the title Remove DELETE /users/:username/subscriptions/:subscriptionId endpoint Remove DELETE /users/:id/subscriptions/:id endpoint Jan 11, 2024
@chenhunghan chenhunghan merged commit 3cf3c1d into main Jan 11, 2024
7 checks passed
@chenhunghan chenhunghan deleted the fix/remove-delete-subscription branch January 11, 2024 12:42
panuhorsmalahti pushed a commit that referenced this pull request Jun 28, 2024
* Remove DELETE /users/:username/subscriptions/:subscriptionId endpoint

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Remove tests

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Fix lint

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

---------

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
panuhorsmalahti added a commit that referenced this pull request Jun 28, 2024
* feat: publish from release/v12

* fix: integration tests

* Remove `DELETE /users/:id/subscriptions/:id` endpoint (#530)

* Remove DELETE /users/:username/subscriptions/:subscriptionId endpoint

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Remove tests

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Fix lint

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

---------

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Remove unused `UserService.getUserSubscription` (#533)

* Remove unused UserService.getUserSubscription

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Remove tests

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

---------

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Drop the need to SSO certificate for SAML (#520)

* Drop the need to SSO certificate for SAML

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

* Fix tests and type

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

---------

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>

---------

Signed-off-by: Hung-Han (Henry) Chen <[email protected]>
Co-authored-by: Henry Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants