feat: demo cluster api #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
panuhorsmalahti
commented
Jun 27, 2024
•
panuhorsmalahti
commented
- Add service for getting the demo cluster
- Update Node.js to 18
- Fix integration tests not working
- Fix to not run some unit tests in integration tests
panuhorsmalahti
force-pushed
the
feat/demo-cluster
branch
5 times, most recently
from
3b7168c to
31a5dd2
Compare
panuhorsmalahti
force-pushed
the
feat/demo-cluster
branch
from
31a5dd2 to
df72b1c
Compare
ixrock
approved these changes
Jun 28, 2024
| } | ||
| } | ||
|
|
||
| export { DemoClusterService }; |
There was a problem hiding this comment.
Why not export right-away at place of definition?
There was a problem hiding this comment.
No idea, just following convention of other files
panuhorsmalahti
added a commit
that referenced
this pull request
Jun 28, 2024
panuhorsmalahti
added a commit
that referenced
this pull request
Jun 28, 2024
panuhorsmalahti
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.