fix potential memory leak with virtual destructor

leovandriel · Mar 15, 2018 · 02952da · 02952da
1 parent c8738ba
commit 02952da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/caffe2/util/model.h b/include/caffe2/util/model.h
@@ -13,7 +13,7 @@ class ModelUtil {
   ModelUtil(NetDef &init_net, NetDef &predict_net,
             const std::string &name = "");
   ModelUtil(NetUtil &init, NetUtil &predict);
-  ~ModelUtil();
+  virtual ~ModelUtil();
 
   void AddDatabaseOps(const std::string &name, const std::string &data,
                       const std::string &db, const std::string &db_type,

diff --git a/src/cvplot/internal.h b/src/cvplot/internal.h
@@ -42,7 +42,7 @@ class Trans {
 
   Trans(cv::Mat &buffer, int alpha) : Trans(buffer) { setup(alpha); }
 
-  ~Trans() { flush(); }
+  virtual ~Trans() { flush(); }
 
   cv::Mat &get() const { return (interim_ != NULL ? *interim_ : original_); }