fix: simplify connection upgrade #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unifies inbound/outbound upgrade - Adds default timeouts for inbound/outbound upgrades and stream protocol negotation - Ensure tcp listener closes sockets when upgrade times out
Merged
2color
reviewed
Sep 25, 2024
|
|
||
| await attemptClose(maConn, { |
There was a problem hiding this comment.
Was the source of the problem that attemptClose would close but not abort?
There was a problem hiding this comment.
Not exactly, it was calling .close which throw if closing gracefully fails, and then call .abort, but we were doing it in response to an error condition so we should just .abort and move on.
As it turns out this hasn't solved the problem completely but it has made it a little better so we're getting closer:
Before:
After:
I think the bug may be in @libp2p/tls, without it the "inbound pending" count stays near 0 the whole time:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixes #2537
Fixes #2477
Change checklist