Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine Linux 3.21 #479

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Alpine Linux 3.21 #479

merged 1 commit into from
Jan 4, 2025

Conversation

crazy-max
Copy link
Member

No description provided.

@crazy-max
Copy link
Member Author

Database migration fails since Alpine 3.21 as of now SSL is required with mysql client: https://github.com/librenms/docker/actions/runs/12610894411/job/35145956067?pr=479#step:8:133

Updating database schema...
   INFO  Preparing database.  
  Creating migration table .......................................... 6ms DONE
   INFO  Loading stored database schemas.  
  database/schema/mysql-schema.sql ................................. 13ms FAIL
In Process.php line 270:
  The command "mysql  --user="${:LARAVEL_LOAD_USER}" --password="${:LARAVEL_L  
  OAD_PASSWORD}" --host="${:LARAVEL_LOAD_HOST}" --port="${:LARAVEL_LOAD_PORT}  
  " --database="${:LARAVEL_LOAD_DATABASE}" < "${:LARAVEL_LOAD_PATH}"" failed.  
  Exit Code: 1(General error)                                                  
  Working directory: /opt/librenms                                             
  Output:                                                                      
  ================                                                             
  Error Output:                                                                
  ================                                                             
  mysql: Deprecated program name. It will be removed in a future release, use  
   '/usr/bin/mariadb' instead                                                  
  ERROR 2026 (HY000): TLS/SSL error: SSL is required, but the server does not  
   support it                                                                  
[cont-init.d] 04-svc-main.sh: exited 1.

Last commit of this PR skips SSL by default when checking connection to the database but we can't pass the --skip-ssl during database migration afaik.

There is also this warning:

  mysql: Deprecated program name. It will be removed in a future release, use  
   '/usr/bin/mariadb' instead  

@murrant Is it possible to have an option to set a custom mysql client binary instead of having this hardcoded in librenms? And for the database migration or other mysql commands, could we also have a way to pass global parameters so we can handle --skip-ssl in the container?

@crazy-max crazy-max force-pushed the alpine-3.21 branch 2 times, most recently from 8e531c3 to 3bb69cb Compare January 4, 2025 14:23
@crazy-max
Copy link
Member Author

Ok I was able to skip ssl entirely for the mysql client by using a global conf.

@crazy-max crazy-max marked this pull request as ready for review January 4, 2025 14:36
@crazy-max crazy-max merged commit 74d179c into librenms:master Jan 4, 2025
5 checks passed
@crazy-max crazy-max deleted the alpine-3.21 branch January 4, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant