Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Rodio to v0.9 #383

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Lock Rodio to v0.9 #383

merged 1 commit into from
Oct 9, 2019

Conversation

andrewburgess
Copy link
Contributor

rodio pushed a change (RustAudio/rodio@0151398) to, updating the dependency cpal to v0.10, which is incompatible with the current librespot implementation.

This wouldn't be noticeable when working with librespot directly based on how Cargo resolves dependencies (I think, still figuring this whole Rust thing out), but if librespot is being used as a dependency in another project, then the newer cpal crate also gets pulled in, and librespot won't compile.

The change in rodio has only occurred in the repository, there hasn't been a new version published, so I figured it would be better to pin the dependency version for the time being.

@willstott101
Copy link
Contributor

I'll have to look properly later, but could we bump cpal? Eventually I think we're going to want to use cpal directly, Rodio is mostly about audio processing, rather than simplifying playback (even though it does happen to provide some extra helpful bits).

@willstott101
Copy link
Contributor

I agree we should pin the version, but it may have to be a revision because there might be unreleased bug fixes too.

@andrewburgess
Copy link
Contributor Author

That's fair. RustAudio/cpal@51eba20 changed things up a bit so /playback/src/audio_backend/rodio.rs would need to be reworked to deal with the changed definitions

@willstott101
Copy link
Contributor

0.9.0 looks like it'll be fine, I didn't know they'd actually released a new version since RustAudio/rodio#220

LGTM

@ashthespy ashthespy merged commit 70024d5 into librespot-org:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants