fix: Reload image state selection each time you select another one (… #1508
Conversation
| * @memberof ButtonAccessibilityImageAlt | ||
| * @method componentWillReceiveProps | ||
| */ | ||
| componentWillReceiveProps() { |
There was a problem hiding this comment.
Hey @georgel-pop-lr, why did you used componentWillReceiveProps in this case? The fix is working but I would know more about it :)
There was a problem hiding this comment.
Hi @diegonvs
@georgel-pop-lr is on PTO now.
The fix was created based on the ButtonLinkEdit: https://github.com/liferay/alloy-editor/blob/master/src/components/buttons/button-link-edit.jsx
More details here: https://issues.liferay.com/browse/PTR-2775?focusedCommentId=2576007&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2576007
Could you plesae merge this change and release it in a new alloy-editor version?
Thanks, Roland
There was a problem hiding this comment.
Hi @diegonvs,
Yes, as @rolandpakai said I inspired myself on https://github.com/liferay/alloy-editor/blob/master/src/components/buttons/button-link-edit.jsx
Let me know if anything else is needed.
Regards.
There was a problem hiding this comment.
Hi @diegonvs,
Will we upgrade alloyeditor on master as well?
Also, let us know when a new version is available.
Regards.
fix: Reload image state selection each time you select another one (#1508)
We can use https://issues.liferay.com/browse/LPS-143258 to upgrade alloy-editor version in the portal.