Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@clayui/language-picker): LPD-45714 Add security margin #5914

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

veroglez
Copy link
Member

@veroglez veroglez commented Jan 15, 2025

Hi guys!,

I’m sending this pull request where we’re contributing a new component to Clay according to this Epic https://liferay.atlassian.net/browse/LPD-17787.

It’s a Language Picker and it has two variants:

  • A basic language picker.
  • A language picker with translations, where each item in the picker is accompanied by a label indicating the translation status.
Screen.Recording.2025-01-15.at.5.49.42.PM.mov

As shown in the video, both variants support a small size and the option to hide the trigger text.

A new feature in the translation variant is the addition of a label to indicate the progress of a translation. This can be useful in cases where the language selector considers more than one field, such as in a form. Along with the existing labels (Default, Translated, and Untranslated), this progress label is now included.

In the code I have also added all the tests that I think are necessary, if you consider that I have to add any more, do not hesitate to tell me.

Could you review it? Any feedback is welcome.

Thanks in advance! 😄

cc @drakonux

@veroglez veroglez changed the title Lpd 45714 feat(@clayui/language-picker): LPD-45714 Add security margin Jan 15, 2025
@veroglez
Copy link
Member Author

@pat270, Could you help me with the styles of the picker options? It seems that the label is misaligned with the rest of the elements (icon, flag, text)

styles

@pat270
Copy link
Member

pat270 commented Jan 16, 2025

@veroglez Sure I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants