Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker image release tag process #9407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve docker image release tag process #9407

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a80137
improve docker image release tag process
abhay084 Jan 8, 2025
12304d3
exclude tag if it container .rc in release tag
abhay084 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,17 @@ jobs:
if: github.event.schedule == '0 0 * * *'
run: |
echo "RELEASE_VERSION=master" >> $GITHUB_ENV
echo "IMAGE_TAG=daily-testing-$(date -u +%Y%m%d),${DOCKER_REPO}/${DOCKER_IMAGE}:daily-testing-only" >> $GITHUB_ENV
echo "IMAGE_TAG=daily-testing-$(date -u +%Y%m%d)" >> $GITHUB_ENV
abhay084 marked this conversation as resolved.
Show resolved Hide resolved

- name: Build and push
id: docker_build
uses: lightninglabs/gh-actions/[email protected]
with:
push: true
platforms: linux/amd64,linux/arm64
tags: "${{ env.DOCKER_REPO }}/${{ env.DOCKER_IMAGE }}:${{ env.IMAGE_TAG }}"
tags: |
"${{ env.DOCKER_REPO }}/${{ env.DOCKER_IMAGE }}:${{ env.IMAGE_TAG }}"
"${{ env.DOCKER_REPO }}/${{ env.DOCKER_IMAGE }}:latest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only tag latest for non-RC builds. So this should match on the env.IMAGE_TAG to not contain .rc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a condition to check if that contains ".rc" and update tag with latest if "rc " is not found there.

build-args: checkout=${{ env.RELEASE_VERSION }}

- name: Image digest
Expand Down