Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3308 Drag and drop text composer #3321

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tddang-linagora
Copy link
Contributor

Issue

Demo

Screen.Recording.2024-12-04.at.16.20.14.mov

Copy link

github-actions bot commented Dec 4, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3321.

@tddang-linagora
Copy link
Contributor Author

Attachments don't attach to composer when Drag & Drop on bottom bar
Text is replaced when dragging another text

Screen.Recording.2024-12-05.at.12.16.01.mov

dab246
dab246 previously approved these changes Dec 6, 2024
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rebase it

fileSize: bytes?.length ?? 0,
bytes: bytes,
isInline: item.platformFormats.firstOrNull?.startsWith(Constant.imageType),
type: item.platformFormats.firstOrNull,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

Suggested change
type: item.platformFormats.firstOrNull,
type: item.platformFormats.firstOrNull ?? 'application/octet-stream',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hoangdat
Copy link
Member

hoangdat commented Dec 12, 2024

  • maybe a side effect in typing in to, cc, bcc fields. We type and enter -> chip will be created. Right now in PR, no chip was created

Current in Prod

Screen.Recording.2024-12-12.at.15.12.33.mov

@tddang-linagora
Copy link
Contributor Author

tddang-linagora commented Dec 12, 2024

maybe a side effect in typing in to, cc, bcc fields. We type and enter -> chip will be created. Right now in PR, no chip was created

Reproducible on master

Screen.Recording.2024-12-12.at.16.03.43.mov

@hoangdat
Copy link
Member

hoangdat commented Dec 12, 2024

  • need loading when drag n drop file to drop file zone

@tddang-linagora
Copy link
Contributor Author

need loading when drag n drop file to drop file zone

Screen.Recording.2024-12-12.at.17.07.09.mov

@hoangdat
Copy link
Member

hoangdat commented Dec 16, 2024

  • please check again, loading dialog of current version
image

@tddang-linagora
Copy link
Contributor Author

please check again, loading dialog of current version

Screen.Recording.2024-12-16.at.11.25.13.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants