[Next] Add get_pipeline() API #707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to enable the full set of effect in the CinnamonBurnMyWindows extension, I need access to OffscreenEffect's CoglPipeline in Cjs. I had hopped that making get_target() available to Cjs (PR linuxmint#702) would give me access to the pipeline, but it turns out that get_target() is returning the target as a CoglMaterial which I probably should have known would only give me access to the CoglMaterial APIs in Cjs. This proposed change copies the get_target() code and renames the copy to get_pipeline() and returns the target as a CoglPipeline rather than casting it to a CoglMaterial. I am not setup to build muffin for testing these changes, but the changes are minor modifications to copies of the existing get_target() code. If these changes are accepted, I am not sure what Cinnamon version it would be included in so I didn't update the libmuffin0.symbols file to include get_pipeline with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable the full set of effect in the CinnamonBurnMyWindows extension, I need access to OffscreenEffect's CoglPipeline in Cjs. I had hopped that making get_target() available to Cjs (PR #702) would give me access to the pipeline, but it turns out that get_target() is returning the target as a CoglMaterial which I probably should have known would only give me access to the CoglMaterial APIs in Cjs. This proposed change copies the get_target() code and renames the copy to get_pipeline() and returns the target as a CoglPipeline rather than casting it to a CoglMaterial.
I am not setup to build muffin for testing these changes, but the changes are minor modifications to copies of the existing get_target() code. If these changes are accepted, I am not sure what Cinnamon version it would be included in so I didn't update the libmuffin0.symbols file to include get_pipeline with this PR.