add mutex locks and unlocks to xviewer_list_store #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #201
It seems
XviewerListStore
had aGMutex
in its private section, but it was only used inxviewer_list_store_remove_thumbnail_job
andxviewer_list_store_add_thumbnail_job
i added it to most otherXviewerListStore
methods as i seemed fit. There might be some cases i overlooked.I am not sure how well glib handles cases like this:
would this cause glib to crash? or are such cases get handled gracefully? If not: then there might be some race conditions left.
(example from
xviewer_list_store_thumbnail_unset
)