feat: allow excluding date from the survey name when generating path TDE-1261 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DE-1261 Co-authored-by: amfage <[email protected]> Co-authored-by: paulfouquet <[email protected]>
paulfouquet
requested review from
l0b0,
blacha,
amfage,
MDavidson17 and
tawera-manaena
l0b0
reviewed
Sep 16, 2024
l0b0
reviewed
Sep 16, 2024
3 tasks
l0b0
approved these changes
Sep 29, 2024
paulfouquet
deleted the
feat/allow-excluding-date-survey-name-in-path-tde-1261
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.1...v4.5.0) (2024-09-29) ### Features * allow excluding date from the survey name when generating path TDE-1261 ([#1067](#1067)) ([057e4d9](057e4d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
blacha
pushed a commit
that referenced
this pull request
Sep 30, 2024
…DE-1261 (#1067) Co-authored-by: amfage <[email protected]> Co-authored-by: paulfouquet <[email protected]> #### Motivation In some cases, the date should not be part of the survey name in the dataset path. For example, the Nationally combined DEMs dataset path should be `s3://nz-elevation/new-zealand/new-zealand/dem_1m/2193/`. #### Modification - add a --no-date-in-survey-path flag that can be pass to the `generate-path` command to not include the date in the survey name. #### Checklist - [x] Tests updated - [x] Docs updated - [x] Issue linked in Title --------- Co-authored-by: amfage <[email protected]>
blacha
pushed a commit
that referenced
this pull request
Sep 30, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.1...v4.5.0) (2024-09-29) ### Features * allow excluding date from the survey name when generating path TDE-1261 ([#1067](#1067)) ([057e4d9](057e4d9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Oct 7, 2024
#### Motivation Allowing the generate-path template to use the new flag available linz/argo-tasks#1067 #### Modification add a new parameter to handle the flag #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title --------- Co-authored-by: Victor Engmark <[email protected]>
amfage
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Nov 14, 2024
#### Motivation Allowing the generate-path template to use the new flag available linz/argo-tasks#1067 #### Modification add a new parameter to handle the flag #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title --------- Co-authored-by: Victor Engmark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: amfage [email protected]
Co-authored-by: paulfouquet [email protected]
Motivation
In some cases, the date should not be part of the survey name in the dataset path. For example, the Nationally combined DEMs dataset path should be
s3://nz-elevation/new-zealand/new-zealand/dem_1m/2193/.Modification
generate-pathcommand to not include the date in the survey name.Checklist