revert: PR #1090 ensure EAI_AGAIN middleware is added to new file systems TDE-1268 #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amfage
changed the title
paulfouquet
approved these changes
Oct 1, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.2](v4.5.1...v4.5.2) (2024-10-01) ### Reverts * PR [#1090](#1090) ensure EAI_AGAIN middleware is added to new file systems TDE-1268 ([#1093](#1093)) ([ddda2e0](ddda2e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts "fix: ensure EAI_AGAIN middleware is added to new file systems TDE-1268 (#1090)"
This reverts commit 48ec902.
Motivation
Release v4.5.1 of Argo Tasks caused workflows (e.g. when running
tileindex-validate) to fail with the following error:{"level":60,"time":1727812404265,"pid":14,"hostname":"test-afage-tileindex-validate-sq9t2-main-1070049358","id":"01J94TA0KEYQ4MZCHHXCPCMQYY","err":{"type":"TypeError","message":"Cannot set properties of undefined (setting 'onFileSystemCreated')","stack":"TypeError: Cannot set properties of undefined (setting 'onFileSystemCreated')\n at setupS3FileSystem (file:///app/fs.register.js:68:46)\n at fsClient.credentials.onFileSystemCreated (file:///app/fs.register.js:72:13)\n at FsAwsS3ProviderV3.find (file:///app/node_modules/@chunkd/source-aws/build/provider.js:100:85)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n at async FsAwsS3V3.details (file:///app/node_modules/@chunkd/source-aws/build/s3.fs.js:90:31)\n at async asyncFilter (file:///app/utils/chunk.js:7:22)\n at async FileSystemAbstraction.toArray (file:///app/node_modules/@chunkd/core/build/index.js:49:22)\n at async getFiles (file:///app/utils/chunk.js:64:26)\n at async Object.load (file:///app/commands/tileindex-validate/tileindex.validate.js:27:23)\n at async Object.handler (file:///app/commands/tileindex-validate/tileindex.validate.js:198:23)"},"msg":"Command:Failed"}Modification
Revert PR #1090.
Checklist