Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update compiling with babel section #1298

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[docs] Update compiling with babel section #1298

merged 2 commits into from
Jan 25, 2024

Conversation

augustjk
Copy link
Member

Fixes #1275

babel recommends babel.config.json over the .js.

Copy link

github-actions bot commented Jan 18, 2024

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1298-dfa0ba9---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1298-fa32a81---lit-dev-5ftespv5na-uc.a.run.app/

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

npm install --save-dev @babel/core
npm install --save-dev @babel/plugin-proposal-class-properties
npm install --save-dev @babel/plugin-proposal-decorators
npm install --save-dev @babel/core @babel/cli @babel/preset-env @babel/plugin-proposal-decorators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there isn't a horizontal scroll bar, is there an alternative where this is broken up over multiple lines, maybe using \? Although this is a nit, and the newline variant may be more distracting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I like the multi-line better.
image

@augustjk augustjk merged commit 4529f77 into main Jan 25, 2024
15 checks passed
@augustjk augustjk deleted the publishing-babel branch January 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Update publishing section babel recommendation
2 participants